-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access to AIX machines to provide coverage #470
Comments
Not at all, @gibm has been helpful all around! Giving him access sounds good to me. |
@joaocgreis Thanks! Just FYI, I merged my work/other Github accounts under @gibfahn, so I'm using that rather than @gibm. |
Just a heads up: me/@joaocgreis figured out why machines sometimes 'fell out' of iptables. Fixed! |
@joaocgreis can I take your response as the second required approver ? If so my default path would be to add his key to the AIX/PPC machines as that limits access to just the required set. @nodejs/build FYI, if @joaocgreis acts as the second app rover I'll go ahead in the next few days unless I hear objections before then. |
@mhdawson sure, I approve. (Sorry if I was not clear before) |
Ok, @gibfahn keys are on the AIX machines and I'll look at adding him to the PPC ones. Sounds like he is going to be onboarded as a collaborator. At that point I'll probably ask that we just get him access in the manner that we would give ongoing access to a collaborator instead. |
Since Gibson is now a collaborator I'd like to propose we just give him access to the test keys so that he has access to the PPC, AIX and 390 machines. Will discuss in WG meting today. |
SGTM |
Suggesting we close this in favor of #514 (once landed) |
Agreed |
While I was away on vacation the firewall config for the AIX machines was dropped somehow and then AIX was removed from the CI runs.
We need more coverage to investigate issues on AIX. In this case it only took a few minutes to investigate and then the fix to the firewall config to get things going again.
I'd like to get @gibm access limited to the AIX machines (or possibly AIX and PPC machines)
He works at IBM. He meets some of the requirements for temporary access in: https://github.com/nodejs/build/blob/master/doc/process/special_access_to_build_resources.md based on this subset of the criteria:
commented, etc on 42 issues since April 2016)
@nodejs/build can I get an approver ?
The text was updated successfully, but these errors were encountered: