-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CI/CD for PRs to iojs/website #57
Comments
The concern was raised during the first WG meeting about running untrusted code on a PR. This was in reference to the iojs codebase though. That being said, with the website repo, I don't see a reason why we couldn't offload the work to TravisCI or Codeship. |
I like the approach suggested by @rvagg in our last meeting wrt having trusted collaborators for full runs within our own ci. |
Would that be overkill for a website repository? |
Sorry, I somehow missed that this was only about |
|
you'd better file an issue over at iojs/website to get buy-in for this, no point in pushing forward if they don't care |
Good point @rvagg, added nodejs/iojs.org#231 |
This is a "nice-to-have" but at the top of our list right now is just to trigger the gulp build on each commit/re-deploy so we can stop checking in "rebuild" commits all the time :) |
@mikeal I wasn't capturing this necessarily for "right now" but just to make sure it's in an issue. Do we have an issue for auto build on commit? |
Arguing that #236 is more relevant and contains more info. Also, auto-testing PR's are ways off. Closing. |
Would be nice to have pull requests to iojs/website automatically trigger a build and deployment to a staging server and then comment in the PR With the link to an ephemeral domain.
The text was updated successfully, but these errors were encountered: