Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI/CD for PRs to iojs/website #57

Closed
kenperkins opened this issue Feb 21, 2015 · 10 comments
Closed

Enable CI/CD for PRs to iojs/website #57

kenperkins opened this issue Feb 21, 2015 · 10 comments

Comments

@kenperkins
Copy link

Would be nice to have pull requests to iojs/website automatically trigger a build and deployment to a staging server and then comment in the PR With the link to an ephemeral domain.

@retrohacker
Copy link

The concern was raised during the first WG meeting about running untrusted code on a PR. This was in reference to the iojs codebase though.

That being said, with the website repo, I don't see a reason why we couldn't offload the work to TravisCI or Codeship.

@jbergstroem
Copy link
Member

I like the approach suggested by @rvagg in our last meeting wrt having trusted collaborators for full runs within our own ci.

@retrohacker
Copy link

Would that be overkill for a website repository?

@jbergstroem
Copy link
Member

Sorry, I somehow missed that this was only about website. Yeah, overkill indeed.

@retrohacker
Copy link

website does not have any unit tests and we do not have access to the settings for that repo. If we did propose this to the website WG, what would be the scope of the build team's involvement?

  • Give build team access to website repo to configure and maintain CI.
  • Setup CI server for website repo.
  • CI ensures gulp task completes without error (no guarantee what it generated is correct).
  • Develop unit tests for website repo.
  • Deploy upon a successful CI test after merging into master.

@rvagg
Copy link
Member

rvagg commented Feb 22, 2015

you'd better file an issue over at iojs/website to get buy-in for this, no point in pushing forward if they don't care

@kenperkins
Copy link
Author

Good point @rvagg, added nodejs/iojs.org#231

@mikeal
Copy link
Contributor

mikeal commented Feb 22, 2015

This is a "nice-to-have" but at the top of our list right now is just to trigger the gulp build on each commit/re-deploy so we can stop checking in "rebuild" commits all the time :)

@kenperkins
Copy link
Author

@mikeal I wasn't capturing this necessarily for "right now" but just to make sure it's in an issue. Do we have an issue for auto build on commit?

@jbergstroem
Copy link
Member

Arguing that #236 is more relevant and contains more info. Also, auto-testing PR's are ways off. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants