You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was looking at #685 (comment), and I noticed that the combination filter for node-test-commit-linux is full of a load of stuff that is no longer required.
As I understand it, we currently build everything on every platform, so we could remove the combination filter (and NODES_SUBSET) entirely.
The other thing that might be helpful is to use Label expression rather than slaves, as it allows you to copy and paste the labels in rather than having to scroll through that tiny view and click on things. Otherwise it's exactly the same:
I'm quite keen not to unilaterally change things, so does anyone have any feedback?
The text was updated successfully, but these errors were encountered:
Combination filter: Happy to welcome a simplification for this! There are at least 3 mechanisms for selecting what configurations run for what versions:
NODES_SUBSET: This is used to support testing versions 0.10 and 0.12 (and iojs at some point). Can we already delete that? It will no longer be possible to test 0.10 and 0.12 (at least without knowing what configurations can be ignored). I suspect testing doc only changes also uses this.
NODE_MAJOR_VERSION: I introduced this one to compile with VS2013 only for <=v6.x, I believe it is the cleanest way to achieve this. It is used by the Windows jobs, please do not delete it. Others could be converted to this mechanism.
An if in the beginning of the Jenkins script: (used at least by node-test-commit-linux to exclude clang) I don't like this one because it will show a configuration as run and green when it is actually not supported and fails.
I was looking at #685 (comment), and I noticed that the combination filter for node-test-commit-linux is full of a load of stuff that is no longer required.
As I understand it, we currently build everything on every platform, so we could remove the combination filter (and
NODES_SUBSET
) entirely.The other thing that might be helpful is to use
Label expression
rather thanslaves
, as it allows you to copy and paste the labels in rather than having to scroll through that tiny view and click on things. Otherwise it's exactly the same:I'm quite keen not to unilaterally change things, so does anyone have any feedback?
The text was updated successfully, but these errors were encountered: