Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Jenkins configs #696

Closed
gibfahn opened this issue Apr 24, 2017 · 2 comments
Closed

Clean up Jenkins configs #696

gibfahn opened this issue Apr 24, 2017 · 2 comments
Assignees

Comments

@gibfahn
Copy link
Member

gibfahn commented Apr 24, 2017

I was looking at #685 (comment), and I noticed that the combination filter for node-test-commit-linux is full of a load of stuff that is no longer required.

NODES_SUBSET=="all_nodes" || NODES_SUBSET=="io.js" || (NODES_SUBSET=="0.12" && 
["centos5-32","centos5-64","centos6-64","centos7-64","debian8-64","debian8-x86", 
"ubuntu1204-64","ubuntu1404-32","ubuntu1404-64","ubuntu1504-64"].contains(nodes)) || 
(NODES_SUBSET=="0.10" && ["centos5-32","centos5-64","centos6-64","centos7-64","debian8-64",
"ubuntu1204-64","ubuntu1404-32","ubuntu1404-64","ubuntu1504-64"].contains(nodes))

As I understand it, we currently build everything on every platform, so we could remove the combination filter (and NODES_SUBSET) entirely.


The other thing that might be helpful is to use Label expression rather than slaves, as it allows you to copy and paste the labels in rather than having to scroll through that tiny view and click on things. Otherwise it's exactly the same:

image

I'm quite keen not to unilaterally change things, so does anyone have any feedback?

@gibfahn gibfahn self-assigned this Apr 24, 2017
@joaocgreis
Copy link
Member

Combination filter: Happy to welcome a simplification for this! There are at least 3 mechanisms for selecting what configurations run for what versions:

  • NODES_SUBSET: This is used to support testing versions 0.10 and 0.12 (and iojs at some point). Can we already delete that? It will no longer be possible to test 0.10 and 0.12 (at least without knowing what configurations can be ignored). I suspect testing doc only changes also uses this.
  • NODE_MAJOR_VERSION: I introduced this one to compile with VS2013 only for <=v6.x, I believe it is the cleanest way to achieve this. It is used by the Windows jobs, please do not delete it. Others could be converted to this mechanism.
  • An if in the beginning of the Jenkins script: (used at least by node-test-commit-linux to exclude clang) I don't like this one because it will show a configuration as run and green when it is actually not supported and fails.

Label expression: I'm ok if you want to change.

@gibfahn
Copy link
Member Author

gibfahn commented Sep 16, 2017

This should probably still be done, but I'm going to be optimistic and hope that #838 will handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants