jenkins,win: fix buildpulse for rebased PRs #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
force-pushed
the
mefi-buildpulse-fix
branch
from
377ed44
to
004ca41
Compare
StefanStojanovic
changed the title
|
A friendly reminder for @nodejs/build to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the last 2 weeks, BuildPulse PoC's been in place in a part of the Windows CI. I noticed that part of the builds were uploaded, but not processed. After investigating it, I learned those were the PR builds for which rebasing the feature branch on the master was required. The issue there was that
GIT_COMMITenvironment variable was not the SHA code of the commit being tested because of rebasing.After discussing this issue with @siddhantdange, he proposed a change, which I tried and it works. That change is in this PR.
Pinging @nodejs/build for review,
Refs: #3653