Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ubuntu 12.04 from all citgm smoker runs #431

Closed
gdams opened this issue Jun 2, 2017 · 5 comments
Closed

remove ubuntu 12.04 from all citgm smoker runs #431

gdams opened this issue Jun 2, 2017 · 5 comments
Labels
CI

Comments

@gdams
Copy link
Member

gdams commented Jun 2, 2017

We don't really need to run citgm on ubuntu 12.04 anymore. @gibfahn says that it has been removed from the node test commit flows for node 7 and above
@gdams gdams added the CI label Jun 2, 2017
@gibfahn
Copy link
Member

gibfahn commented Jun 2, 2017

See: nodejs/node-v8#2

Skipped for Node 8 and above actually, but given that we're not planning to do any more releases of 7 it doesn't really matter.

@gdams
Copy link
Member Author

gdams commented Jun 2, 2017

@MylesBorins any objections?

@gdams gdams mentioned this issue Jun 2, 2017
Closed
@MylesBorins
Copy link
Contributor

MylesBorins commented Jun 2, 2017 •
edited
Loading

We still are doing v6 releases for a while.

edit: we can skip the platform on higher versions

@targos
Copy link
Member

targos commented Dec 16, 2018

The groovy script handles this correctly

@targos targos closed this as completed Dec 16, 2018
@richardlau
Copy link
Member

Also for reference; nodejs/build#1616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MylesBorins @targos @richardlau @gibfahn @gdams