Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noisy errors hides real errors when testing jest #875

Closed
SimenB opened this issue Sep 8, 2021 · 4 comments
Closed

Noisy errors hides real errors when testing jest #875

SimenB opened this issue Sep 8, 2021 · 4 comments

Comments

@SimenB
Copy link
Member

SimenB commented Sep 8, 2021

  • Node Version: N/A
  • CitGM Version: N/A
  • Platform: N/A

Ref nodejs/node#40030 (comment), it seems #868 is not enough. @targos could you expand a bit on what's wrong? I would have thought removing the examples would also remove mongo, but apparently not?
@SimenB SimenB mentioned this issue Sep 8, 2021
Closed
@targos
Copy link
Member

targos commented Sep 8, 2021

Here's an example: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2754/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/jest_v27_1_0/

@targos
Copy link
Member

targos commented Sep 8, 2021

I just realized that there is no citgm release that includes #868 🤦🏻

@targos
Copy link
Member

targos commented Sep 8, 2021

I just published version 8.0.2. This should be fixed.

@targos targos closed this as completed Sep 8, 2021
@SimenB
Copy link
Member Author

SimenB commented Sep 8, 2021

Ah, wonderful 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimenB @targos