feat: verify integrity signature when downloading from npm registry #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
commented
Mar 22, 2024
arcanis
reviewed
Mar 27, 2024
| @@ -200,7 +204,7 @@ export async function installVersion(installTarget: string, locator: Locator, {s | |||
|
|
|||
| stream.pipe(sendTo); | |||
|
|
|||
| const algo = build[0] ?? `sha256`; | |||
| const algo = build[0] ?? `sha512`; | |||
There was a problem hiding this comment.
Because that’s what npm registry uses for the signature: they sign a combination of the package name & version and the SHA512 of the package archive. See https://docs.npmjs.com/verifying-registry-signatures for reference.
Co-authored-by: Maël Nison <nison.mael@gmail.com>
aduh95
commented
Mar 30, 2024
arcanis
approved these changes
Apr 12, 2024
aduh95
commented
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user has not provided any hash (so when running
corepack up/corepack use …), and the package manager is downloaded from the npm registry, we can verify the signature.Related to #10.
BREAKING CHANGE: attempting to download a version from the npm registry (or a mirror) that was published using the now deprecated PGP signature (Yarn ≤1.22.18, Yarn Berry ≤4.0.0-rc.43, pnpm ≤8.4.0) without providing a hash will trigger an error. Users can disable the signature verification by setting
COREPACK_INTEGRITY_KEYS="".