-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
doc: add meeting minutes for 28th October
Fixes: #438 PR-URL: #440 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
- Loading branch information
1 parent
477e787
commit 75d0f74
Showing
1 changed file
with
64 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
# Node.js Diagnostics WorkGroup Meeting 2020-10-28 | ||
|
||
## Links | ||
|
||
* **Recording**: https://www.youtube.com/watch?v=kjgGc1_KcuQ | ||
* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/438 | ||
* **Minutes Google Doc**: https://docs.google.com/document/d/1-rm5JJxdq9Muwd4oqufhE6gP4xyu0Ob8g7Fc_FcLUyA/edit | ||
|
||
## Present | ||
|
||
* Diagnostics team: @nodejs/diagnostics | ||
* Stephen Belanger (@qard) | ||
* Rafael Gonzaga (@rafaelgss) | ||
* Michael Dawson (@mhdawson) | ||
* Chengzhong Wu (@legendecas) | ||
* Gireesh Punathil (@gireeshpunathil) | ||
|
||
|
||
## Agenda | ||
|
||
## Announcements | ||
|
||
Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. | ||
|
||
### nodejs/node | ||
|
||
* lib: add span API to diagnostics_channel [#35534](https://github.com/nodejs/node/pull/35534) | ||
* Waiting on diagnostics channel to land first | ||
|
||
* lib: make diagnostics_channel async iterable [#35532](https://github.com/nodejs/node/pull/35532) | ||
* Waiting on diagnostics channel to land first | ||
|
||
* Proposal: mark AsyncResource and AsyncLocalStorage as stable [#35286](https://github.com/nodejs/node/issues/35286) | ||
* Seems like there is consensus that AsyncResource should be able to become stable | ||
* For AsyncLocalStorage, we need to come up/agree exit criteria. Gireesh pasted in | ||
Starting point for exit criteria based on previous features that went experimental->stable | ||
https://github.com/nodejs/node/issues/35286#issuecomment-708899145 | ||
|
||
* lib: create diagnostics_channel module [#34895](https://github.com/nodejs/node/pull/34895) | ||
* Waiting on reviews, needs more TSC approvals | ||
|
||
* Node.js' internal scripts should be hidden in the inspector. [#11893](https://github.com/nodejs/node/issues/11893) | ||
* wait until we have Mary who might have a better insight | ||
|
||
### nodejs/diagnostics | ||
|
||
* Identify async_hooks use cases beyond AsyncLocalStorage [#437](https://github.com/nodejs/diagnostics/issues/437) | ||
* Good start on getting some feedback/capture the use case | ||
|
||
* Add ioredis to problematic-modules.md [#430](https://github.com/nodejs/diagnostics/pull/430) | ||
* Just waiting on replacement issues to be opened. | ||
|
||
* Node CPU Profiling Roadmap [#148](https://github.com/nodejs/diagnostics/issues/148) | ||
* skip for this week as Mary is Champion/has context | ||
|
||
* \[async_hooks\] stable API - tracking issue [#124](https://github.com/nodejs/diagnostics/issues/124) | ||
* closed in favor of https://github.com/nodejs/diagnostics/issues/437 | ||
|
||
|
||
## Q&A, Other | ||
|
||
## Upcoming Meetings | ||
|
||
* **Node.js Foundation Calendar**: https://nodejs.org/calendar |