Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bestpractices: add documentation structure #333

Closed
wants to merge 0 commits into from
Closed

bestpractices: add documentation structure #333

wants to merge 0 commits into from

Conversation

gireeshpunathil
Copy link
Member

Refs: #254 (comment)
Refs: #254 (comment)

@nodejs/diagnostics @mhdawson @hekike

mhdawson
mhdawson approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmarchini
mmarchini approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have one file per use-case, but I'm fine with this structure as well.

gireeshpunathil added a commit that referenced this pull request Oct 22, 2019
@gireeshpunathil
doc: add documentation structure
ddf7d13 
Refs: #254

PR-URL: #333
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@gireeshpunathil
Copy link
Member Author

landed as ddf7d13

@legendecas legendecas mentioned this pull request Feb 4, 2020
Merged
@legendecas legendecas mentioned this pull request Feb 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@mmarchini mmarchini mmarchini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gireeshpunathil @mmarchini @mhdawson