Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add meeting minutes for 28th October #440

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

gireeshpunathil
Copy link
Member

Fixes: #438

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


## Announcements

*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently produces a broken result:

*Extracted from diag-agenda labelled issues and pull requests from the nodejs org prior to the meeting.


It should be:

Suggested change
*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.
Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

Extracted from diag-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes: nodejs#438
PR-URL: nodejs#440
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@gireeshpunathil
Copy link
Member Author

landed in 75d0f74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js Diagnostics WorkGroup Meeting 2020-10-28
5 participants