Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

Docs seem to get truncated when viewing on the iPhone #92

Closed
girishla opened this issue Mar 16, 2016 · 15 comments
Closed

Docs seem to get truncated when viewing on the iPhone #92

girishla opened this issue Mar 16, 2016 · 15 comments

Comments

@girishla
Copy link

Not sure if this is the right place to create this issue but Docs seem to get truncated when viewing on the iPhone
iOS version 9.2.1

@eljefedelrodeodeljefe
Copy link
Contributor

Can you send in a screenshot?

@girishla
Copy link
Author

The "Event:error" line is the last I can see in this page. It doesn't allow me to scroll any further. I've tried on Chrome and Safari on multiple iphones. Same behaviour.

img_0145

@eljefedelrodeodeljefe
Copy link
Contributor

Interesting. Couldn't reproduce with with chrome's window size emulator, but will check it back at work against some devices.

@eljefedelrodeodeljefe
Copy link
Contributor

Okay, this is reproduceable on saucelabs. I'll gather some more information and open a ticket on the main repo. Will close it then here. Good call @girishla

@girishla
Copy link
Author

Great, ta

@girishla girishla reopened this Mar 16, 2016
@girishla
Copy link
Author

will let you close this when appropriate.

@benjamingr
Copy link
Member

They're scrollable to the right and behave exactly like code comments in GitHub and StackOverflow. I think the current behavior is fine.

@eljefedelrodeodeljefe
Copy link
Contributor

Nah, he doesn't mean the codeblocks, but that you can't scroll past a certain point.

iOS 9.2, iPhone 6, process.html https://saucelabs.com/beta/tests/e2c86c418a5646bab619e9c4b4e2a6c7/watch
iOS 8.4, iPhone 6, stream.html https://saucelabs.com/beta/tests/fdc9c31581a24841bd8688555374f7f9/watch
iOS 9.2, iPhone 6, stream.html https://saucelabs.com/beta/tests/9e1d5547403b4ffd9f4f01ff9bf4d968/watch

@benjamingr
Copy link
Member

I tested on a real device and I can scroll all the way down - when I reach code blocks I have to stop scrolling and then resume it from a point that is not in the code block which is annoying.

I think this happens because the scrolling gets "stuck" on the code block - we can fix this by listening to the scroll event and handling this case.

@eljefedelrodeodeljefe
Copy link
Contributor

Could you be more precise please. Hardware, OS, Page? Because it's very easy to reproduce the faulty behaviour at sauce labs tbh.

@benjamingr
Copy link
Member

Sure - It's faulty, but I can scroll down. This is a real iPhone 6 with iOS 9.2 (haven't upgraded since).

@stevemao
Copy link
Contributor

I never had good experience viewing docs on my phone and I gave up... If there is any good third party docs viewer we could probably learn from it.

@eljefedelrodeodeljefe
Copy link
Contributor

Closed in favor for nodejs/node#5861 Thanks for reporting!

@girishla
Copy link
Author

Thanks for fixing!

@Knighton910
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants