Notify new commits on a PR ?

[targos]

Just saw this on the react project: facebook/react#6896 (comment)

[phillipj]

I'm +1 on this. IMO it should be done for rebases as well.

One thing that comes to mind though; we should probably include throttling on this from the beginning, by only creating one of these comments per day or so. We wouldn't want to be too noisy with these comments.

[targos]

totally. We should also wait a bit after detecting the commit and not comment at all if a human does in the meantime

[jbergstroem]

I'm not a fan of it :( I don't use emails so this would just add to notification noise. Perhaps have the bot email people connected to threads somehow?

[phillipj]

@jbergstroem ahhh yeah guess that would double the notifications, not nice at all. Looks like we're able to get a hold of the email of all comment authors via the GH API.

[targos]

I just received an email from GitHub notifying new commits in a PR I was involved in. Is it a new feature ?

[MylesBorins]

@targos it is a new github feature

[targos]

That's nice. Then I guess we can close this issue.