Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support of utf8 encoding #105

Merged
merged 3 commits into from
May 21, 2021

Conversation

owl-from-hogvarts
Copy link
Contributor

this fix is needed for node-gyp/lib/find-python.js to
work properly with paths, which contain non-ASCII chars

see nodejs/node-gyp#2254 for more info

this fix is needed for node-gyp/lib/find-python to
work properly with paths, which contain non-ASCII chars
@owl-from-hogvarts
Copy link
Contributor Author

@cclauss hi) pls review my changes. they should be exact same as in my PR to node-gyp in gyp part. thanks in advance

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM (I don't know the Windoze bit.)

pylib/gyp/easy_xml.py Outdated Show resolved Hide resolved
@owl-from-hogvarts
Copy link
Contributor Author

@targos will be this PR merged soon?

@gengjiawen gengjiawen requested a review from targos May 19, 2021 09:51
@targos
Copy link
Member

targos commented May 19, 2021

I'm not able to review this, sorry.

@targos targos removed their request for review May 19, 2021 09:53
@owl-from-hogvarts
Copy link
Contributor Author

Who i can ask for review?

@gengjiawen gengjiawen merged commit 4d0f93c into nodejs:main May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants