Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some Python lint issues #200

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix: some Python lint issues #200

merged 2 commits into from
Jul 17, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 17, 2023

Related to nodejs/node-gyp#2886

% ruff .

pylib/gyp/generator/make.py:1992:53: UP032 [*] Use f-string instead of `format` call
pylib/gyp/generator/msvs.py:687:34: RUF015 [*] Prefer `next(iter(outputs))` over `list(outputs)[0]`

% ruff --fix .

Found 2 errors (2 fixed, 0 remaining).

@cclauss cclauss requested a review from richardlau July 17, 2023 15:52
@cclauss cclauss merged commit d2dfe4e into nodejs:main Jul 17, 2023
@cclauss cclauss deleted the fix-Python-lint-issues branch July 17, 2023 18:12
@github-actions github-actions bot mentioned this pull request Jul 17, 2023
Merged
@cclauss cclauss mentioned this pull request Jul 20, 2023
Merged
4 tasks
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @richardlau