Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quotes for command in msvs generator #217

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Oct 25, 2023

The msvs generator only added quotes for arguments of the action, the command itself should have quotes too.

Without this change actions will fail when python binary is placed in a path with spaces in it.

Refs nodejs/node#48462.

/cc @gengjiawen

The msvs generator only added quotes for arguments of the action, the command itself should have quotes too.

Without this change actions will fail when python binary is placed in a path with spaces in it.
@targos targos merged commit d3b7bcd into nodejs:main Oct 25, 2023
20 checks passed
@zcbenz zcbenz deleted the patch-2 branch November 6, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants