Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to detect flavor if compiler path include white spaces #240

Merged
merged 12 commits into from
Apr 23, 2024

Conversation

toyobayashi
Copy link
Contributor

This PR is a follow-up optimization to #222.

In previous implementation of GetCrossCompilerPredefines, if CC_target include white space

"/Users/Toyo Li/wasi-sdk/bin/clang"

the cmd passed to subprocess.Popen is incorrect:

['"/Users/Toyo', 'Li/wasi-sdk/bin/clang"', ...]

This PR fixed this issue, and will raise error if process exit code is not 0.

@toyobayashi
Copy link
Contributor Author

This two windows CI failed with different errors, seems have nothing to do with changes in this PR.

https://github.com/nodejs/gyp-next/actions/runs/8523184021/job/23344932415
https://github.com/nodejs/gyp-next/actions/runs/8523270071/job/23345184290

pylib/gyp/common.py Outdated Show resolved Hide resolved
pylib/gyp/common.py Outdated Show resolved Hide resolved
pylib/gyp/common_test.py Outdated Show resolved Hide resolved
pylib/gyp/common.py Outdated Show resolved Hide resolved
pylib/gyp/common.py Outdated Show resolved Hide resolved
toyobayashi and others added 2 commits April 2, 2024 22:36
Co-authored-by: Christian Clauss <cclauss@me.com>
pylib/gyp/common.py Outdated Show resolved Hide resolved
@legendecas legendecas merged commit f3b9753 into nodejs:main Apr 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants