Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using outdated dependency flags dependency confusion attack [PR available] #71

Open
jackwhelpton opened this issue Apr 17, 2024 · 2 comments

Comments

@jackwhelpton
Copy link
Contributor

Expected Behavior

Prior to v1.9.0, acorn-import-attributes (then called acorn-import-assertions) used an implicit/not fully qualified reference to a dependency (test262).

This causes security scanning tools to flag a possible dependency confusion attack.

Actual Behavior

No security warning

Steps to Reproduce the Problem

  1. Run security scan (e.g. Orca) on code using this repo

Specifications

  • Version: 1.7.3
  • Platform: (all)
  • Subsystem: (all)
@jackwhelpton
Copy link
Contributor Author

jackwhelpton commented Apr 17, 2024

I've raised a PR #70 that should resolve this, let me know what it would take to get this merged. My first contribution to this repo, so be gentle/let me know if edits are required.

@jackwhelpton jackwhelpton changed the title Using outdated dependency flags dependency confusion attack [MR available] Using outdated dependency flags dependency confusion attack [PR available] Apr 19, 2024
@trentm
Copy link
Contributor

trentm commented May 6, 2024

Now that #70 is merged and 1.7.4 is released, I believe this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants