Skip to content

Commit

Permalink
node: remove bad fn call and check
Browse files Browse the repository at this point in the history
These two lines exist because of a screw up on my part while combining
MakeCallback() and MakeDomainCallback().

The reason it never broke core tests is because any paths it would have
broken were rerouted to AsyncWrap::MakeCallback(). The only case that
node::MakeCallback() handles anymore is setImmediate().

Fix: a1da024 "node, async-wrap: remove MakeDomainCallback"
PR-URL: #2157
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
trevnorris committed Jul 27, 2015
1 parent 99d9d7e commit 93660c8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1092,8 +1092,6 @@ Handle<Value> MakeCallback(Environment* env,
return Undefined(env->isolate());
}
}
env->tick_callback_function()->Call(process, 0, nullptr);
CHECK_EQ(env->context(), env->isolate()->GetCurrentContext());

if (try_catch.HasCaught()) {
return Undefined(env->isolate());
Expand Down

0 comments on commit 93660c8

Please sign in to comment.