fs: use kMaxLength from binding
#1903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ const Readable = Stream.Readable; | |||
| const Writable = Stream.Writable; | |||
|
|
|||
| const kMinPoolSpace = 128; | |||
| const kMaxLength = require('internal/smalloc').kMaxLength; | |||
| const kMaxLength = process.binding('smalloc').kMaxLength; | |||
There was a problem hiding this comment.
Femto-nit: you have one space too many after the '='.
|
LGTM with style nit. Can you update the commit log to explicitly call out graceful-fs and add a link to the issue you filed there? I don't want people to construe this change as an implicit promise of support for eval-ing core modules. |
vkurchatkin
force-pushed
the
fix-graceful-fs
branch
from
717ad44
to
443a72c
Compare
|
@bnoordhuis PTAL at the message |
|
LGTM but can you use |
|
Sorry, I mean: EDIT: The commit history is a bit inconsistent in its use of Refs vs. See. |
This allows `graceful-fs` to evaluate `fs` source without access to internals. This is a temporary workaround that makes npm work. See: isaacs/node-graceful-fs#41 Fixes: nodejs#1898
vkurchatkin
force-pushed
the
fix-graceful-fs
branch
from
443a72c
to
4fd4838
Compare
vkurchatkin
added a commit
that referenced
this pull request
Jun 5, 2015
This allows `graceful-fs` to evaluate `fs` source without access to internals. This is a temporary workaround that makes npm work. See: isaacs/node-graceful-fs#41 Fixes: #1898 PR-URL: #1903 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 2dcef83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows userland modules to evaluate
fssourcewithout access to internals.
Fixes: #1898
R=@evanlucas