build: don't run lint from test-ci #1965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing.
|
I am not sure if this is a good idea. What if people execute only the relevant test cases instead of |
|
@thefourtheye the context for this is that we're splitting off linting to a separate pre-test in CI which can be run and fail quickly before even compiling. |
|
Oh. Cool then :-) |
|
LGTM. Running the linter first/separately sounds like a great idea. |
|
LGTM |
jbergstroem
added a commit
that referenced
this pull request
Jun 15, 2015
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing. PR-URL: #1965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Revewied-By: Evan Lucas <evanlucas@me.com>
|
Merged in 8d8a26e. Thanks for the review. |
orangemocha
pushed a commit
to orangemocha/node
that referenced
this pull request
Jun 17, 2015
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing. Cherry-picked from nodejs/node@8d8a26e Original commit metadata follows: PR-URL: nodejs/node#1965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Revewied-By: Evan Lucas <evanlucas@me.com>
orangemocha
pushed a commit
to orangemocha/node
that referenced
this pull request
Jun 29, 2015
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing. Cherry-picked from nodejs/node@8d8a26e Original commit metadata follows: PR-URL: nodejs/node#1965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Revewied-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Dummy Reviewer <dummy@reviewer.org> PR-URL: #11
rvagg
pushed a commit
to rvagg/io.js
that referenced
this pull request
Jul 3, 2015
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing. PR-URL: nodejs#1965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Revewied-By: Evan Lucas <evanlucas@me.com>
orangemocha
pushed a commit
to orangemocha/node
that referenced
this pull request
Jul 7, 2015
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing. Cherry-picked from nodejs/node@8d8a26e Original commit metadata follows: PR-URL: nodejs/node#1965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Revewied-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Dummy Reviewer <dummy@reviewer.org> PR-URL: #11
This was referenced Jun 22, 2023
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing.
Note to person landing this: Don't merge until we have the linter up and running (#1955 and nodejs/build#109).