test: add containsLine function

nodejs · Nov 30, 2017 · 65c577c · 65c577c
1 parent dd401ff
commit 65c577c
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/test/usage-test.js b/test/usage-test.js
@@ -2,6 +2,10 @@
 const tape = require('tape');
 const common = require('./common');
 
+function containsLine(lines, re) {
+  return lines.some(line => re.test(line.trim()));
+}
+
 tape('usage messages', (t) => {
   t.timeoutAfter(15000);
 
@@ -15,29 +19,28 @@ tape('usage messages', (t) => {
   sess.stderr.linesUntil(/USAGE/, (err, lines) => {
     t.error(err);
     const re = /^error: USAGE: v8 print expr$/;
-    t.ok(lines.some(line => re.test(line.trim())), 'print usage message');
+    t.ok(containsLine(lines, re), 'print usage message');
     sess.send('v8 source list');
   });
 
   sess.stderr.linesUntil(/USAGE/, (err, lines) => {
     t.error(err);
     const re = /^error: USAGE: v8 source list$/;
-    t.ok(lines.some(line => re.test(line.trim())), 'list usage message');
+    t.ok(containsLine(lines, re), 'list usage message');
     sess.send('v8 findjsinstances');
   });
 
   sess.stderr.linesUntil(/USAGE/, (err, lines) => {
     t.error(err);
     const re = /^error: USAGE: v8 findjsinstances \[flags\] instance_name$/;
-    t.ok(lines.some(line => re.test(line.trim())),
-         'findjsinstances usage message');
+    t.ok(containsLine(lines, re), 'findjsinstances usage message');
     sess.send('v8 findrefs');
   });
 
   sess.stderr.linesUntil(/USAGE/, (err, lines) => {
     t.error(err);
     const re = /^error: USAGE: v8 findrefs expr$/;
-    t.ok(lines.some(line => re.test(line.trim())), 'findrefs usage message');
+    t.ok(containsLine(lines, re), 'findrefs usage message');
     sess.quit();
     t.end();
   });