Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

hot reload modules w/ es6 modules #459

Closed
seiyria opened this issue Dec 20, 2019 · 7 comments
Closed

hot reload modules w/ es6 modules #459

seiyria opened this issue Dec 20, 2019 · 7 comments

Comments

@seiyria
Copy link

seiyria commented Dec 20, 2019

Hey! @Fishrock123 pointed me here for something I was thinking about.

While I don't have a particularly large project, back when all I had was a require cache, I could clear it out to "hot reload" a file/module/chunk of code. It wasn't the best possible way to get my code running without a restart (nodemon or similar) but it worked without forcing me to do fresh restarts all the time.

I'm using Typescript these days and, with that, ES6 imports (like most are I imagine). For reference, I'm making a game but it has a few hundred files (which is probably not a lot in comparison to some larger applications), and restarting it (I'm using ts-node-dev at the moment) still takes a solid 20-30 seconds to get everything running again. I think it would be much easier if I could hotswap my code in by somehow clearing out parts of the ES6 module cache.

I realize after talking with @Fishrock123 that ES6 modules are meant to be immutable and probably for good reason, but is it possible node will allow a dev to override this issue in development environments?

@bmeck
Copy link
Member

bmeck commented Dec 21, 2019

Hiya @seiyria ! Thanks for the investigation.

Unfortunately neither the spec, nor the engines allow for hot reloading at this time. There could be future investigations with things like the debugger protocol are likely what I'd recommend but cannot provide a path forward on how to do this currently. We are actively discussing an unload API for the cache, but it likely is not going to do what most hot swapping/mocking libraries do today and might require some migrations of the tools using the current techniques.

@weswigham
Copy link
Contributor

There could be future investigations with things like the debugger protocol are likely what I'd recommend but cannot provide a path forward on how to do this currently.

The inspector protocol's Debugger.setScriptSource?

@jkrems
Copy link
Contributor

jkrems commented Dec 30, 2019

The inspector protocol's Debugger.setScriptSource?

IIRC there's an open bug somewhere in the V8 tracker for setScriptSource ("live edit") for modules. I asked a few years ago and it wasn't a priority. I hope that'll change eventually though. 🤞 Last I saw was: https://chromium.googlesource.com/v8/v8.git/+/6b6ed60155314fc608504b235382909ebedc23d8

@jkrems
Copy link
Contributor

jkrems commented Dec 30, 2019

To immediately correct myself: Looks like thanks to @ak239 Debugger.setScriptSource does work these days for modules! v8/v8@0cec56a

@boneskull
Copy link

Ref: nodejs/tooling#51

@MylesBorins MylesBorins added the modules-agenda To be discussed in a meeting label Aug 26, 2020
@giltayar
Copy link

You could do this with an ESM loader. When I implemented a mocking library for testdouble (https://github.com/testdouble/quibble) I had to implement "deleting a module" because in a test you can mock a module differently many times.

Obviously, you can't do this by deleting the module from the cache, because as mentioned above, this isn't available. But the next best thing is to load the module again as a separate "module".

You can see the explanation of how it works here: https://dev.to/giltayar/mock-all-you-want-supporting-es-modules-in-the-testdouble-js-mocking-library-3gh1.

@MylesBorins
Copy link
Contributor

Removing the label, we've discussed this extensively and @giltayar has one way to solve this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants