Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Unit test coverage for Value class #1054

Closed
JckXia opened this issue Aug 27, 2021 · 3 comments
Closed

[Test] Unit test coverage for Value class #1054

JckXia opened this issue Aug 27, 2021 · 3 comments

Comments

@JckXia
Copy link
Member

JckXia commented Aug 27, 2021

class methods
Value
Covered Value()
Covered Value(napi_env env, napi_value value)
Covered static Value From(napi_env env, const T&value)
Covered operator napi_value
Covered bool operator ==(const Value& other) const
Covered bool operator != (const Value& other) const
Covered bool StrictEquals(const Value& other) const
Covered Napi::Env Value::Env() const
Covered bool IsEmpty()
Covered(see external.cc) napi_valuetype Type() const
Covered bool IsUndefined() const
Covered bool IsNull()
Covered bool IsBoolean() const
Covered bool IsNumber() const
Covered (See bigint.js) bool IsBigInt() const
Covered ( See date.cc) bool IsDate() const
Covered bool IsString() const
Covered bool IsSymbol() const
Covered bool IsArray() const
Covered bool IsArrayBuffer() const
Covered bool IsTypedArray() const
Covered bool IsObject() const
Covered bool IsFunction() const
Covered bool IsPromise() const
Covered bool IsDataView() const
Covered (see buffer.cc) bool IsBuffer() const
Covered bool IsExternal() const
Used by many function test suites, (i.e asynccontext.cc) templateT As() const
Covered MaybeOrValue ToBoolean()
Covered MaybeOrValue ToNumber()
Covered MaybeOrValue ToString()
Covered MaybeOrValue ToObject()

Unless otherwise specified, the methods have been covered by tests written in value.cc

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Dec 24, 2021
@NickNaso NickNaso removed the stale label Jan 10, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@JckXia
Copy link
Member Author

JckXia commented May 6, 2022

Closed by pull request #1170

@JckXia JckXia closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants