-
Notifications
You must be signed in to change notification settings - Fork 339
SyntaxError occures during benchmark run #134
Comments
Thanks @abodalevsky - I can repro this. I think the problem is that node-cc doesn't support some internal v8 methods today- the problem is this line in the benchmark: %OptimizeFunctionOnNextCall appears to be an internal v8 method. node-chakracore doesn't support shimming v8 internal methods today (since they're supposed to be internal to v8). @kunalspathak @jianchun - can you guys confirm this is the case? |
That's correct. Most of these functions that are exposed using |
Can those benchmarks be disabled in node-chakracore somehow? |
@joaocgreis can you help? Is it possible to disable these benchmarks in node-chakracore? Would the changes you made to CI recently help on this front? |
@digitalinfinity The tests and the benchmarks use different runners, the benchmarks' runner is less complex and it's not possible to disable benchmarks. What we could do is add a For a rough comparison, those lines can probably be skipped, but it wouldn't be a truthful comparison then. cc @bzoz |
As a user, I'd rather have something that just runs out of the box and I can compare the benchmarks that do actually run between v8 and chakracore, or between chakracore releases. |
Fixed by nodejs/node#9615 |
When I tried to execute benchmark test benchmark\buffers\buffer-compare-instance-method.js I got the following error:
to reproduce, go to benchmark\buffers and run:
The same test runs on node/v8 without issues
The text was updated successfully, but these errors were encountered: