This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
build: merged conditions for v8_inspector #80
Merged
+12
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
kunalspathak
force-pushed
the
node_gyp_fix
branch
from
cc310a8
to
89dbaf8
Compare
kunalspathak
pushed a commit
to kunalspathak/node-chakracore
that referenced
this pull request
Jun 29, 2016
"supportsOverrideToString" was originally added to make old FastBuffer work. Buffer has long switched to TypedArray implementation. This is no longer used. Fix nodejs#80 Reviewed-by: @kunalspathak
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
After recent sync to nodejs/master there were 2 conditions
section for cctest. Merged those sections. Thanks @jianchun
for pointing it out.