Finish move to nodejs org #9
Conversation
juliangruber
commented
May 19, 2022
•
juliangruber
commented
- Update license
- Bin name
|
We should also fix the docs and the GHA workflows. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
@aduh95 I'm not allowed to rename the repo, are you? |
|
Also, how shall we update the LICENSE file? |
juliangruber
changed the title
I don’t think we should rename the repo, |
README.md
Outdated
| possible to skip all top level tests except for a selected subset by passing | ||
| the `only` option to the tests that should be run. When a test with the `only` | ||
| option set is run, all subtests are also run. The test context's `runOnly()` | ||
| method can be used to implement the same behavior at the subtest level. | ||
|
|
||
| ```js | ||
| // Assume node-core-test is run with the --test-only command-line option. | ||
| // Assume test is run with the --test-only command-line option. |
There was a problem hiding this comment.
I think we need ticks to remove the ambiguity around the package name.
| // Assume test is run with the --test-only command-line option. | |
| // Assume `test` is run with the `--test-only` command-line option. |
There was a problem hiding this comment.
Actually, test is a bash builtin too, so it's also not a good cli name 🤔
There was a problem hiding this comment.
not sure what to do about this. do you have an idea?
There was a problem hiding this comment.
We could keep node-core-test, use npx test (and yarn test on Yarn projects), or possibly both.
We probably should. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
| const { bin } = require('../../package.json') | ||
|
|
||
| process.execPath = path.resolve(__dirname, '..', '..', bin['node-core-test']) | ||
| process.execPath = path.resolve(__dirname, '..', '..', bin.test) |
There was a problem hiding this comment.
We could get rid of the magic string here (feel free to ignore, that's going to be useful only in the unlikely event of this pacakge switching name ever again).
| const { bin } = require('../../package.json') | |
| process.execPath = path.resolve(__dirname, '..', '..', bin['node-core-test']) | |
| process.execPath = path.resolve(__dirname, '..', '..', bin.test) | |
| const { bin, name } = require('../../package.json') | |
| process.execPath = path.resolve(__dirname, '..', '..', bin[name]) |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Update documentation and binary names to reflect the change from `node-core-test` to `test`. Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
