Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: check CI job result #308

Closed
refack opened this issue Nov 16, 2018 · 3 comments
Closed

FR: check CI job result #308

refack opened this issue Nov 16, 2018 · 3 comments
Labels
feature request New features for node-core-utils git-node pr-checker Issues related to pr checker

Comments

@refack
Copy link
Contributor

refack commented Nov 16, 2018

I was about to suggest that if the PR is labeled V8 Engine we should check for a V8 CI job, but I just saw that we already do 😄 :

i  Last V8 CI on 2018-11-10T22:17:13Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/1838/
i  Last Lite PR Pipeline CI on 2018-11-14T17:57:34Z: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1615/

So how about we query Jenkins for it's status?

@refack refack added feature request New features for node-core-utils git-node pr-checker Issues related to pr checker labels Nov 16, 2018
@joyeecheung
Copy link
Member

joyeecheung commented Nov 17, 2018

So..the code for querying Jenkins and parsing the results are already part of ncu-ci, I guess we just need some glue to invoke them from git-node..

But I am not 100% sure since our CI is still not yet in a false-positive-free state

@refack
Copy link
Contributor Author

refack commented Nov 17, 2018

I'll try to draft something this weekend.

@mmarchini
Copy link
Contributor

Implemented on #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New features for node-core-utils git-node pr-checker Issues related to pr checker
Projects
None yet
Development

No branches or pull requests

3 participants