Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(land): prevent duplicate and self-refs #478

Merged
merged 1 commit into from
Aug 18, 2020
Merged

fix(land): prevent duplicate and self-refs #478

merged 1 commit into from
Aug 18, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 15, 2020 •
edited
Loading

Closes #350.
Closes #133.

Handles two potential edge cases:

  • Duplicate Refs: and Fixes: items
  • A ref to one's own PR.

@codecov
Copy link

codecov bot commented Aug 15, 2020 •
edited
Loading

Codecov Report

Merging #478 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files          34       34           
  Lines        1660     1660           
=======================================
  Hits         1371     1371           
  Misses        289      289
Impacted Files Coverage Δ
lib/links.js 88.73% <100.00%> (ø)
lib/metadata_gen.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5c572...eee4d58. Read the comment docs.

@codebytere codebytere changed the title fix: prevent duplicate and self-refs fix(land): prevent duplicate and self-refs Aug 15, 2020
@codebytere codebytere mentioned this pull request Aug 18, 2020
Closed
@codebytere codebytere requested a review from a team August 18, 2020 02:47
@codebytere codebytere merged commit 95300fd into nodejs:master Aug 18, 2020
@codebytere codebytere deleted the prevent-ref-fix-dups branch August 18, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git-node: check if there are duplicates in Refs and PR-URL Detect double Refs and Fixes entries.
2 participants
@codebytere @targos