Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous "Commit message is missing PR-URL" error #506

Open
codebytere opened this issue Oct 4, 2020 · 1 comment
Open

Erroneous "Commit message is missing PR-URL" error #506

codebytere opened this issue Oct 4, 2020 · 1 comment
Labels

Comments

@codebytere
Copy link
Member

Seen here: nodejs/node#35405

When i proceed anyway, each message nevertheless has all requisite info:

node on git:v12.x-staging ❯ git rebase upstream/v12.x-staging -i -x "git node land --amend"
Executing: git node land --amend
   ⚠  Found PR-URL: , skipping..
--------------------------------- New Message ----------------------------------
module: named exports for CJS via static analysis

PR-URL: https://github.com/nodejs/node/pull/35249
Backport-PR-URL: https://github.com/nodejs/node/pull/35405
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
--------------------------------------------------------------------------------
? Use this message? Yes
[detached HEAD 65ffce152b] module: named exports for CJS via static analysis
 Author: Guy Bedford <guybedford@gmail.com>
 Date: Thu May 14 22:40:37 2020 -0700
 20 files changed, 1926 insertions(+), 85 deletions(-)
 create mode 100755 deps/cjs-module-lexer/.gitignore
 create mode 100755 deps/cjs-module-lexer/LICENSE
 create mode 100755 deps/cjs-module-lexer/README.md
 create mode 100755 deps/cjs-module-lexer/lexer.js
 create mode 100755 deps/cjs-module-lexer/package.json
 create mode 100644 test/es-module/test-esm-cjs-exports.js
 create mode 100644 test/fixtures/es-modules/cjs-exports.mjs
 create mode 100644 test/fixtures/es-modules/exports-cases.js
 create mode 100644 test/fixtures/es-modules/exports-cases2.js
 create mode 100644 test/fixtures/es-modules/exports-cases3.js
Executing: git node land --amend
   ⚠  Found PR-URL: , skipping..
@codebytere codebytere added the bug label Oct 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2021

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jan 3, 2021
@targos targos removed the stale label Mar 3, 2021
@targos targos reopened this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants