Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update changelog list when preparing release #712

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

RafaelGSS
Copy link
Member

Refs: #686

lib/prepare_release.js Outdated Show resolved Hide resolved
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS force-pushed the fix/changelog-tag-list branch from 9af5197 to b6db847 Compare July 4, 2023 13:28
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ecb1b7d) 83.38% compared to head (b6db847) 83.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        4158     4158           
=======================================
  Hits         3467     3467           
  Misses        691      691           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -386,7 +386,7 @@ export default class ReleasePreparation {
` ${releaseInfo}, @${username}\n`;

const topHeader =
`<a href="#${lastRef.substring(1)}">${lastRef.substring(1)}</a><br/>`;
`<a href="#${lastRef.substring(1)}">${lastRef.substring(1)}</a>`;
Copy link
Member Author

@RafaelGSS RafaelGSS Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it should match with or without <b>

@RafaelGSS RafaelGSS requested a review from richardlau July 4, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants