-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Todo: Skip the wait check for specific PRs #94
Comments
Hello! It's not possible to retrieve files/diffs at the moment with GraphQL API (https://github.com/joyeecheung/node-core-utils/issues/68#issuecomment-342031633), so I'm afraid we have to wait for the second point. But I can do the first one if there are no incoveniences. |
I would probably suggest holding off. I feel like this is something that needs to be discussed within Node.js itself a bit... IMO a lot of this could be simplified by setting a 24 hour limit (instead of 48 hours) on doc, test & code-and-learn changes. Then it can stop being so arbitrary. /cc @addaleax, @joyeecheung |
Oh, okay @apapirovski, I didn't know that. Thank you! |
New rules landed: nodejs/node#17056 |
Fixed, closing |
Hey!
Related to #89 , and as seen in #92(comment):
doc
andtest
Question: what is the ideal number of files? I would go for three, but I'm not an expert...
The text was updated successfully, but these errors were encountered: