Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose release: v3.5.0 #1049

Closed
Fishrock123 opened this issue Nov 7, 2016 · 10 comments
Closed

Propose release: v3.5.0 #1049

Fishrock123 opened this issue Nov 7, 2016 · 10 comments
Labels

Comments

@Fishrock123
Copy link
Contributor

Fishrock123 commented Nov 7, 2016

It's been a while and some of this stuff looks useful.

  • [37ae7be114] - Try python launcher when stock python is python 3. (Ben Noordhuis) #992
  • [e3778d9907] - Add lots of findPython() tests. (Ben Noordhuis) #992
  • [afc766adf6] - Unset executable bit for .bat files (Pavel Medvedev) #969
  • [ddac348991] - Use push on PYTHONPATH and add tests (Michael Hart) #990
  • [b182a19042] - Revert "add "path-array" dep" (Michael Hart) #990
  • [9c8d275526] - Add --devdir flag. (Ben Noordhuis) #916
  • [7c08b85c5a] - Revert "configure: use "path-array" for PYTHONPATH" (Michael Hart) #990
  • [f6eab1f9e4] - doc: add windows-build-tools to readme (Felix Rieseberg) #970

The add --devdir flag sounds like a minor to me.

cc @nodejs/node-gyp, @bnoordhuis, @rvagg

@bnoordhuis
Copy link
Member

--devdir is semver-minor, yes. It would be great if someone has time to review #919, that would also make a nice addition.

@alanpurple
Copy link

please add VS2017 support to this

@Fishrock123
Copy link
Contributor Author

@alanpurple I suspect that will be the release after if no PR is made very soon. Unfortunately I do not have any expertise in that area so I can't really help. :(

@Fishrock123
Copy link
Contributor Author

I think we should probably just release this already. @bnoordhuis are you ok with that? We can always do another minor once that PR and VS2017 land, but progress is pretty slow.

@bnoordhuis
Copy link
Member

SGTM

@Fishrock123
Copy link
Contributor Author

@bnoordhuis / @rvagg I'm willing to finish this if I can get npm release perms, does anything special need to be done for the changelog or do I just clean up what sounds important and markdownize it?

@Jeff-Lewis
Copy link

@Fishrock123 Can we get pull #1085 skip ValueError for long, list and dict type release asap? I think it's crushing all yarn Windows and ARM users who have bcrypt dependency.

@Fishrock123
Copy link
Contributor Author

Maybe @bnoordhuis or @nodejs/python could review that? Python isn't exactly my familiarity.

@Fishrock123
Copy link
Contributor Author

Looks like that PR is now at #1088

@rvagg
Copy link
Member

rvagg commented Jan 10, 2017

v3.5.0 published

@rvagg rvagg closed this as completed Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants