Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "tap" and "standard" to newer version #2379

Closed
owl-from-hogvarts opened this issue Apr 16, 2021 · 5 comments · Fixed by #2770
Closed

Update "tap" and "standard" to newer version #2379

owl-from-hogvarts opened this issue Apr 16, 2021 · 5 comments · Fixed by #2770

Comments

@owl-from-hogvarts
Copy link
Contributor

owl-from-hogvarts commented Apr 16, 2021

Node-gyp uses to old tap 12.7.0. In fact now last tap version is 15.x.x
Node-gyp uses to old standard package 14.3.4. In fact now last tap version is 16.x.x

@owl-from-hogvarts owl-from-hogvarts changed the title Update tap to newer version Update "tap" and "standard" to newer version Apr 16, 2021
@rvagg
Copy link
Member

rvagg commented Apr 21, 2021

Yeah, we got stuck on 12.x because it dropped support for versions of Node.js that we still needed to support in 13.x+ (we did upgrade but had to roll back). That hasn't been revisited in a while so it might be possible to do it now.

@owl-from-hogvarts
Copy link
Contributor Author

@rvagg the latest changelog states that tap drop node < 10 support. In node-gyp readme there is no states about minimal supported version of node, that is required to run node-gyp, but github checks run tests for node.js 10 and above

@rvagg
Copy link
Member

rvagg commented May 3, 2021

npm has been more aggressive in their minimum version support in the last year or two so it's probably appropriate for us too. Mostly we just need to make sure we don't get ahead of npm, but otherwise we should be able to move forward.
Feel free to do an upgrade and PR it if you want to try and reconcile these things.

@owl-from-hogvarts
Copy link
Contributor Author

lol it seems that the version of standard we use does not know how to work with static keyword and class property decalration syntax:

class foo {
  static bar = 'foobar'
}

that code raise exeption:

Parsing error: Unexpected token =

@owl-from-hogvarts
Copy link
Contributor Author

@rvagg
As i figured out, we can safly update both tap and standard to newest versions.

There «Node.js v10 or higher must be installed to run this program» in readme of npm/cli repo.

According to tap changelog they dropped support of node.js below 10 version

Drop support for node <10

standard drop support of node.js 8 here thus i can make a conclusion that it should support node.js 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants