test: Try msvs-version: [2016, 2019, 2022] #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjiawen
approved these changes
Jul 13, 2022
|
It is unclear to me what GYP_MSVS_OVERRIDE_PATH=C:\Dummy' >> $Env:GITHUB_ENV does. How can we prove that MSVS_VERSION is being used in the testing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try testing on all MSVS_VERSIONs available in the GitHub Actions runner.
NOTE: I am not a Windows person so I might be doing this all wrong. ;-)
It is unclear to me what
GYP_MSVS_OVERRIDE_PATH=C:\\Dummy' >> $Env:GITHUB_ENVdoes.How can we prove that
MSVS_VERSIONis being used in the testing?Checklist
npm install && npm testpassesDescription of change