Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: nopt@6.0.0 #2707

Merged
merged 1 commit into from
Jul 22, 2022
Merged

deps: nopt@6.0.0 #2707

merged 1 commit into from
Jul 22, 2022

Conversation

wraithgar
Copy link
Contributor

Description of change

Updates the nopt dependency to 6.0.0

No functional changes, just dropping old node versions from engines,
linting, and fixing CI.

No functional changes, just dropping old node versions from engines,
linting, and fixing CI.
@cclauss
Copy link
Contributor

cclauss commented Jul 20, 2022

@rvagg
Copy link
Member

rvagg commented Jul 21, 2022

@wraithgar are we expecting npm to bump at the same time? probably good to stay in sync to avoid duplication in deployment: https://github.com/npm/cli/blob/4c945302fc2aa6854dc014fe31d6f5dfa96f7b52/package.json#L100

@wraithgar
Copy link
Contributor Author

wraithgar commented Jul 21, 2022

@rvagg yes the reason this PR is being made is so that we can bump nopt in npm without this module having its own duplicated copy at a lower version

@rvagg rvagg merged commit 8958ecf into nodejs:main Jul 22, 2022
@wraithgar wraithgar deleted the deps/nopt-6.0.0 branch July 22, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants