-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove deprecated Node.js and Python #2868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Jun 9, 2023
cclauss
reviewed
Jun 9, 2023
Removed Node.js v14.x and Python v3.7. Also added Node.js v20.x.
StefanStojanovic
force-pushed
the
mefi-remove-v14
branch
from
June 12, 2023 10:12
cc67479
to
abecdcd
Compare
StefanStojanovic
changed the title
test: remove deprecated node.js v14 from tests
test: remove deprecated node.js and python
Jun 12, 2023
cclauss
reviewed
Jun 12, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
approved these changes
Jun 12, 2023
cclauss
changed the title
test: remove deprecated node.js and python
test: remove deprecated node.js and Python
Jun 12, 2023
StefanStojanovic
changed the title
test: remove deprecated node.js and Python
test: remove deprecated Node.js and Python
Jun 12, 2023
mhdawson
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cclauss
added a commit
to cclauss/node-gyp
that referenced
this pull request
Jun 13, 2023
* test: remove deprecated node.js and python Removed Node.js v14.x and Python v3.7. Also added Node.js v20.x. * Update .github/workflows/tests.yml Co-authored-by: Christian Clauss <cclauss@me.com> --------- Co-authored-by: Christian Clauss <cclauss@me.com>
lukekarrys
pushed a commit
that referenced
this pull request
Dec 2, 2024
* test: remove deprecated node.js and python Removed Node.js v14.x and Python v3.7. Also added Node.js v20.x. * Update .github/workflows/tests.yml Co-authored-by: Christian Clauss <cclauss@me.com> --------- Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Since Node.js v14 has reached its EOL, this PR removes it from GitHub Actions for testing.