Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove deprecated Node.js and Python #2868

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

StefanStojanovic
Copy link
Contributor

Description of change

Since Node.js v14 has reached its EOL, this PR removes it from GitHub Actions for testing.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
Removed Node.js v14.x and Python v3.7. Also added Node.js v20.x.
@StefanStojanovic StefanStojanovic changed the title test: remove deprecated node.js v14 from tests test: remove deprecated node.js and python Jun 12, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss cclauss changed the title test: remove deprecated node.js and python test: remove deprecated node.js and Python Jun 12, 2023
@StefanStojanovic StefanStojanovic changed the title test: remove deprecated node.js and Python test: remove deprecated Node.js and Python Jun 12, 2023
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss merged commit a0b3d1c into nodejs:main Jun 12, 2023
cclauss added a commit to cclauss/node-gyp that referenced this pull request Jun 13, 2023
* test: remove deprecated node.js and python

Removed Node.js v14.x and Python v3.7. Also added Node.js v20.x.

* Update .github/workflows/tests.yml

Co-authored-by: Christian Clauss <cclauss@me.com>

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
lukekarrys pushed a commit that referenced this pull request Dec 2, 2024
* test: remove deprecated node.js and python

Removed Node.js v14.x and Python v3.7. Also added Node.js v20.x.

* Update .github/workflows/tests.yml

Co-authored-by: Christian Clauss <cclauss@me.com>

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants