-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build 32 and 64 bits under Windows #443
Comments
This line would need to be changed |
I also need to change this line to |
I'm not sure why these changes would be necessary. I can compile fine on windows, 32-bit and 64-bit. |
Which version of Visual Studio? ia32 is not a configuration for me, x86 is. Anyways, I have a PR ready you could look at. |
It's hard for me to tell what version appveyor is using, but they seem to have no problem using node-gyp: https://ci.appveyor.com/project/TooTallNate/ref Also my Windows VMs have Visual Studio 2012 Express installed IIRC. |
Here is my PR, it works great in VS 2013 and it's not much of a change. |
+1 on this. The Folder |
closing due to staleness, I think this might be resolved now anyway? |
In order to successfully build for the two configuration under Windows I had to do the following tweaks and I'm wondering if there is value in adding those to the project.
kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;DelayImp.lib;"c:\Users\Laurent\.node-gyp\0.10.28\$(Configuration)\node.lib"
to
kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;DelayImp.lib;"c:\Users\Laurent\.node-gyp\0.10.28\$(Plateform)\node.lib"
.node-gyp\0.10.28\ia32\node.lib
to `.node-gyp\0.10.28\Win32\node.libThe text was updated successfully, but these errors were encountered: