Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 32 and 64 bits under Windows #443

Closed
LaurentGoderre opened this issue May 7, 2014 · 8 comments
Closed

Build 32 and 64 bits under Windows #443

LaurentGoderre opened this issue May 7, 2014 · 8 comments
Labels

Comments

@LaurentGoderre
Copy link
Member

In order to successfully build for the two configuration under Windows I had to do the following tweaks and I'm wondering if there is value in adding those to the project.

  1. Changed the Additional Dependencies from
    kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;DelayImp.lib;"c:\Users\Laurent\.node-gyp\0.10.28\$(Configuration)\node.lib"
    to
    kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;DelayImp.lib;"c:\Users\Laurent\.node-gyp\0.10.28\$(Plateform)\node.lib"
  2. Copy the file .node-gyp\0.10.28\ia32\node.lib to `.node-gyp\0.10.28\Win32\node.lib
@LaurentGoderre
Copy link
Member Author

@LaurentGoderre
Copy link
Member Author

I also need to change this line to Win32 because that's the platform Visual Studio uses

https://github.com/TooTallNate/node-gyp/blob/f19da41b9ae10788bc667e11232f79f9fcad3992/lib/install.js#L270

@TooTallNate
Copy link
Contributor

I'm not sure why these changes would be necessary. I can compile fine on windows, 32-bit and 64-bit.

@LaurentGoderre
Copy link
Member Author

Which version of Visual Studio? ia32 is not a configuration for me, x86 is. Anyways, I have a PR ready you could look at.

@TooTallNate
Copy link
Contributor

It's hard for me to tell what version appveyor is using, but they seem to have no problem using node-gyp: https://ci.appveyor.com/project/TooTallNate/ref

Also my Windows VMs have Visual Studio 2012 Express installed IIRC.

@LaurentGoderre
Copy link
Member Author

Here is my PR, it works great in VS 2013 and it's not much of a change.

#450

@mathiask88
Copy link

+1 on this. The Folder .node-gyp/VERSION/... does not contain Release or Debug that is specified in the *.vcxproj ...\.node-gyp\0.11.13\$(Configuration)\node.lib... But I wonder why this happens. Until now I allways had a Release dir...

@rvagg
Copy link
Member

rvagg commented Jun 20, 2019

closing due to staleness, I think this might be resolved now anyway?

@rvagg rvagg closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants