Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Python 3 #737

Closed
tigerhawkvok opened this issue Sep 20, 2015 · 5 comments
Closed

Convert to Python 3 #737

tigerhawkvok opened this issue Sep 20, 2015 · 5 comments

Comments

@tigerhawkvok
Copy link

Yikes! This was a shocker. I'd expect this back in 2012, but not on the tail end of 2015.

Proposed paths:

Why?

  • It's good practice
  • Python 3, released in 2008, is officially older than the amount of time Python2 has remaining -- which is now just a touch over 4 years. (And, let's be honest -- if you're butting up against the EOL, without at least a year for dependencies to get their stuff in line, you're doing it wrong).
  • Most major projects are Python 3 compatible nowadays -- this makes node-gyp That Legacy Project We Have To Support
@thefourtheye
Copy link
Contributor

I would love to help with Python-3 compatibility, if decided to do so.

@rvagg
Copy link
Member

rvagg commented Sep 21, 2015

Yeah, maybe a good idea, would make life easier for a lot of people. I have prior-art for switching based on Python versions, my main concern here is that since we'd be using a fork for people that have v3 installed there would be disparity between the code being executed, not just the runtime used (unless the v3 fork of gyp can be used with v2?).

The alternative path is a wholesale upgrade, including Node core, and moving to v3 being required, but that would be really painful and we may face bigger barriers getting a gyp fork into core.

@mangecoeur
Copy link

lack of python3 is a huge pain, and only going to get worse as distros like Fedora and Ubuntu default to python3. What needs to happen for this to happen?

@bnoordhuis
Copy link
Member

Upstream gyp would have to convert to python 3, which is unlikely to happen if this 6 year old bug report is anything to go by: https://bugs.chromium.org/p/gyp/issues/detail?id=36

I'll close the issue, it's a duplicate of #193.

@bnoordhuis
Copy link
Member

Work with a python 3 compatible port, like this

For posterity, I think this is a good idea in general but the devil is in the details. gyp files have a lot of python code in them that is executed verbatim (as python 2 code obviously.)

EDIT:

Manually port Gyp as part of the greater nodejs environment (thus becoming the active maintainer). Probably most ideal

This has been discussed before but it's not something I'm really in favor of as long as gyp is still supported upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants