-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebuilt v3.4.2 archive does not exist for OSX 10.11.5, making installation difficult #991
Comments
@mdentremont this output isn't fatal to your application is it? It should just be a deprecation warning even though it is unnecessarily scary. You should take this up with the folks at https://github.com/sass/node-sass or in the dependency that is using node-sass. They probably need to update the version of NAN being bundled with node-sass and that may have already been done in a recent release. @nodejs/addon-api, @nodejs/v8: I'm going to leave this open for now as it overlaps with discussion in #920, we may need to reconsider allowing V8 deprecation warnings like this at runtime because it's pretty intimidating getting a full stack trace. |
Terrible argument. Without warnings, maintainers won't fix their modules until it's too late. This time around people have ample time to upgrade instead of scrambling around when a new major release breaks half the ecosystem. |
163 lines of stderr for a single deprecation warning though, that's pretty terrible. |
Subjective. At any rate, I'll close the issue since it's not node-gyp related. @rvagg You can move over the discussion to nodejs/node if you want. |
OK, perhaps we'll wait and see how much impact this has, it's only gone out with the new 3.4.0 update which has very low adoption so far. Perhaps I'm overreacting but we'll see! |
The warning has been in node.js since v6.0.0. It was fixed in node-sass months ago but @mdentremont is using a quite old version. |
Also note that the warning can be silenced using |
When trying to install an npm lib which has a downstream dependency on node-gyp I get:
Cannot download "https://github.com/sass/node-sass/releases/download/v3.4.2/darwin-x64-48_binding.node"
Due to the 404, npm then tries to manually build node-gyp, which takes a very long time and even after it does build, I get a stacktrace when trying to run my app; this stacktrace is not displayed on the exact same MacBook and same code revision, but just an earlier OSX.
Here's the stack just in case you can think of something I might be doing wrong :(
The text was updated successfully, but these errors were encountered: