Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seems to not account for when a review has been dismissed #14

Closed
sam-github opened this issue Sep 7, 2017 · 4 comments
Closed

seems to not account for when a review has been dismissed #14

sam-github opened this issue Sep 7, 2017 · 4 comments

Comments

@sam-github
Copy link

example: nodejs/node#10747

a

b
@refack
Copy link
Contributor

refack commented Sep 8, 2017

I just encountered that and patched it yesterday 😄.
Just opened PR #15

@joyeecheung
Copy link
Member

Looks like it still doesn't handle nodejs/node#14782 when someone dissmised their own reviews

@joyeecheung
Copy link
Member

joyeecheung commented Oct 15, 2017 •
edited
Loading

Funny enough, it also tries to delete my review (not that I have approved or rejected at that point) from the map when I added a reference with a title containing "dismissed" lol

@joyeecheung joyeecheung mentioned this issue Oct 15, 2017
Merged
@sam-github
Copy link
Author

Looks like @joyeecheung fixed this in #16 (but it can be reopened if that is not the case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sam-github @refack @joyeecheung