From 139dbe8bb70901c62c4a594d2e742f191a1dfb85 Mon Sep 17 00:00:00 2001 From: Shigeki Ohtsu Date: Wed, 17 Jun 2015 10:51:56 +0900 Subject: [PATCH] test: remove 512 bits test in test-tls-dhe.js Test of 512 bits key is failed after upgrading openssl-1.0.1o due to its limit of 768 bits key size. Remove it and start from 1024 bits test. Reviewed-By: Michael Dawson PR-URL: https://github.com/joyent/node/pull/25533 --- test/fixtures/keys/Makefile | 5 +---- test/fixtures/keys/dh512.pem | 4 ---- test/simple/test-tls-dhe.js | 7 +------ 3 files changed, 2 insertions(+), 14 deletions(-) delete mode 100644 test/fixtures/keys/dh512.pem diff --git a/test/fixtures/keys/Makefile b/test/fixtures/keys/Makefile index ee667c60156..f7f9c6495f6 100644 --- a/test/fixtures/keys/Makefile +++ b/test/fixtures/keys/Makefile @@ -1,4 +1,4 @@ -all: agent1-cert.pem agent2-cert.pem agent3-cert.pem agent4-cert.pem agent5-cert.pem ca2-crl.pem ec-cert.pem dh512.pem dh1024.pem dh2048.pem +all: agent1-cert.pem agent2-cert.pem agent3-cert.pem agent4-cert.pem agent5-cert.pem ca2-crl.pem ec-cert.pem dh1024.pem dh2048.pem # @@ -170,9 +170,6 @@ ec-cert.pem: ec-csr.pem ec-key.pem -signkey ec-key.pem \ -out ec-cert.pem -dh512.pem: - openssl dhparam -out dh512.pem 512 - dh1024.pem: openssl dhparam -out dh1024.pem 1024 diff --git a/test/fixtures/keys/dh512.pem b/test/fixtures/keys/dh512.pem deleted file mode 100644 index dcab8db9fbc..00000000000 --- a/test/fixtures/keys/dh512.pem +++ /dev/null @@ -1,4 +0,0 @@ ------BEGIN DH PARAMETERS----- -MEYCQQDpl3okBAjG92NSOaQEsIyqzvJRN06yHuGXunxYVIqxg7TnU8DBZW0ZYyiJ -rJLRA/9b9dCk5DXpq1pFGoAkYLoDAgEC ------END DH PARAMETERS----- diff --git a/test/simple/test-tls-dhe.js b/test/simple/test-tls-dhe.js index 3975c5ed40a..e4f9d847940 100644 --- a/test/simple/test-tls-dhe.js +++ b/test/simple/test-tls-dhe.js @@ -80,11 +80,6 @@ function test(keylen, expectedCipher, cb) { }); } -function test512() { - test(512, 'DHE-RSA-AES128-SHA256', test1024); - ntests++; -} - function test1024() { test(1024, 'DHE-RSA-AES128-SHA256', test2048); ntests++; @@ -100,7 +95,7 @@ function testError() { ntests++; } -test512(); +test1024(); process.on('exit', function() { assert.equal(ntests, nsuccess);