Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

i18n: Allow locating ICU data relative to 'exec_path'. #8983

Closed
srl295 opened this issue Jan 6, 2015 · 1 comment
Closed

i18n: Allow locating ICU data relative to 'exec_path'. #8983

srl295 opened this issue Jan 6, 2015 · 1 comment
Labels

Comments

@srl295
Copy link
Member

srl295 commented Jan 6, 2015

If the user hasn't otherwise specified a directory,
append NODE_EXEPATH_ICUDIR ( default: ../share/node/icu/ )
and set it as the ICU dir.

If we are in small-icu mode, ALSO actually verify the aforementioned
directory exists (thx libuv) and suppress loading the small-icu data
in that case.

(If we aren't in small-icu mode, there's no reason to incur the cost
of hitting the FS to check whether the directory exists or not at
startup time.)

// cc: @tjfontaine @misterdjules

see srl295/node/pull/22 especialy 12d619f for work in progress

@srl295
Copy link
Member Author

srl295 commented Jan 16, 2015

Does the WIP make any sense so far?

@Trott Trott closed this as completed Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants