Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Upstream fix to dictionary properties access to V8 #9147

Closed
misterdjules opened this issue Feb 6, 2015 · 4 comments
Closed

Upstream fix to dictionary properties access to V8 #9147

misterdjules opened this issue Feb 6, 2015 · 4 comments

Comments

@misterdjules
Copy link

The lastest update to mdb_v8 in v0.12 fixed dictionary properties access. This commit touches deps/v8/tools/gen-postmortem-metadata.py with the following changes:

    'Map, instance_size, int, kInstanceSizeOffset',
     'Map, bit_field, char, kBitFieldOffset',
     'Map, bit_field2, char, kBitField2Offset',
-    'Map, bit_field3, SMI, kBitField3Offset',
+    'Map, bit_field3, int, kBitField3Offset',
     'Map, prototype, Object, kPrototypeOffset',
     'NameDictionaryShape, prefix_size, int, kPrefixSize',
     'NameDictionaryShape, entry_size, int, kEntrySize',

These changes should probably be upstreamed to V8.

@misterdjules misterdjules added this to the 0.12.1 milestone Feb 6, 2015
@misterdjules
Copy link
Author

cc @davepacheco

@jasnell
Copy link
Member

jasnell commented Jul 9, 2015

Updated the priority on this to P-1 per nodejs/node#28

@misterdjules misterdjules modified the milestones: 0.12.7, 0.12.8 Jul 10, 2015
@misterdjules misterdjules modified the milestones: 0.12.8, 0.12.7 Jul 10, 2015
@misterdjules
Copy link
Author

@misterdjules
Copy link
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants