Skip to content

Commit

Permalink
deps, v8: fix build torque on windows
Browse files Browse the repository at this point in the history
On windows the torque binary needs to be compiled and linked
with exception semantics and assume V8 is embedded

Fixes: #57
  • Loading branch information
refack authored and nodejs-ci committed May 26, 2018
1 parent b1360b6 commit 28379bd
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions deps/v8/gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -2526,10 +2526,33 @@
'GCC_ENABLE_CPP_RTTI': 'YES', # -frtti
},
'defines': ['ANTLR4CPP_STATIC'],
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
],
'include_dirs': [
'../third_party/antlr4/runtime/Cpp/runtime/src',
'../src/torque',
],
# This is defined trough `configurations` for GYP+ninja compatibility
'configurations': {
'Debug': {
'msvs_settings': {
'VCCLCompilerTool': {
'RuntimeTypeInfo': 'true',
'ExceptionHandling': 1,
},
}
},
'Release': {
'msvs_settings': {
'VCCLCompilerTool': {
'RuntimeTypeInfo': 'true',
'ExceptionHandling': 1,
},
}
},
},
'sources': [
'../src/torque/TorqueBaseVisitor.cpp',
'../src/torque/TorqueBaseVisitor.h',
Expand Down

0 comments on commit 28379bd

Please sign in to comment.