From c66df2bf5c3307f22cd46348d492b2bd2a994f2a Mon Sep 17 00:00:00 2001 From: Jiawen Geng Date: Thu, 17 Mar 2022 11:33:07 +0100 Subject: [PATCH] deps: V8: fix v8-cppgc.h for MSVC Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: https://github.com/nodejs/node/issues/42375 PR-URL: https://github.com/nodejs/node/pull/42657 Reviewed-By: Darshan Sen Reviewed-By: Richard Lau Reviewed-By: Jiawen Geng Reviewed-By: Michael Dawson --- common.gypi | 2 +- deps/v8/include/v8-cppgc.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index b78e804dc10..6c2524520dd 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.1', + 'v8_embedder_string': '-node.2', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8-cppgc.h b/deps/v8/include/v8-cppgc.h index 139af8fdac2..3a6582cd258 100644 --- a/deps/v8/include/v8-cppgc.h +++ b/deps/v8/include/v8-cppgc.h @@ -77,6 +77,9 @@ struct WrapperDescriptor final { }; struct V8_EXPORT CppHeapCreateParams { + CppHeapCreateParams(const CppHeapCreateParams&) = delete; + CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete; + std::vector> custom_spaces; WrapperDescriptor wrapper_descriptor; /**