deps, v8: fix build torque on windows

On windows the torque binary needs to be compiled and linked with exception semantics and assume V8 is embedded Fixes: #57
nodejs · May 24, 2018 · d125781 · d125781
1 parent 491eb0f
commit d125781
Showing 1 changed file with 23 additions and 0 deletions.
diff --git a/deps/v8/gypfiles/v8.gyp b/deps/v8/gypfiles/v8.gyp
@@ -2522,10 +2522,33 @@
         'GCC_ENABLE_CPP_RTTI': 'YES',        # -frtti
       },
       'defines': ['ANTLR4CPP_STATIC'],
+      'defines!': [
+        '_HAS_EXCEPTIONS=0',
+        'BUILDING_V8_SHARED=1',
+      ],
       'include_dirs': [
         '../third_party/antlr4/runtime/Cpp/runtime/src',
         '../src/torque',
       ],
+      # This is defined trough `configurations` for GYP+ninja compatibility
+      'configurations': {
+        'Debug': {
+          'msvs_settings': {
+            'VCCLCompilerTool': {
+              'RuntimeTypeInfo': 'true',
+              'ExceptionHandling': 1,
+            },
+          }
+        },
+        'Release': {
+          'msvs_settings': {
+            'VCCLCompilerTool': {
+              'RuntimeTypeInfo': 'true',
+              'ExceptionHandling': 1,
+            },
+          }
+        },
+      },
       'sources': [
         '../src/torque/TorqueBaseVisitor.cpp',
         '../src/torque/TorqueBaseVisitor.h',