-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI tests are failing or not running at all #146
Comments
Looks like github action problem. Happens before. It seems run now. |
The JS tests seem the most error prone so should we delay them so we can first see if we have lint or C++ issues? Perhaps we should change the execution order from: Lint can be a useful fast-fail and it would be good to ensure that we have no C++ problems even if JS tests fail. |
I am inclined to But there is one thing. @richardlau put some lint task in |
CI will eventually and periodically fail here, because the repository is automatically synced with nodejs/node and then upgraded with the latest version of V8. If there is a specific issue when building in one platform, or a specific test failing, please open individual issues for it. As for any changes on the Build/Test/Linter order, this should be handled on nodejs/node. I'll close this as it doesn't seem there's anything actionable, and the Actions are green right now. |
Is it a problem that our CI tests are either failing or not running at all?
https://github.com/nodejs/node-v8/actions
Related to #144 ?
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
What is the expected behavior?
What do you see instead?
Additional information
The text was updated successfully, but these errors were encountered: