Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests are failing or not running at all #146

Closed
cclauss opened this issue Feb 28, 2020 · 4 comments
Closed

CI tests are failing or not running at all #146

cclauss opened this issue Feb 28, 2020 · 4 comments

Comments

@cclauss
Copy link

cclauss commented Feb 28, 2020

Is it a problem that our CI tests are either failing or not running at all?
https://github.com/nodejs/node-v8/actions

Related to #144 ?

  • Version:
  • Platform:
  • Subsystem:

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

@gengjiawen
Copy link
Member

Looks like github action problem. Happens before. It seems run now.

@cclauss
Copy link
Author

cclauss commented Feb 28, 2020

The JS tests seem the most error prone so should we delay them so we can first see if we have lint or C++ issues? Perhaps we should change the execution order from:
Compile Node.js --> Test JS Suites --> Test C++ Suites --> Make lint # to:
Compile Node.js --> Make lint --> Test C++ Suites --> Test JS Suites # or:
Make lint --> Compile Node.js --> Test C++ Suites --> Test JS Suites

Lint can be a useful fast-fail and it would be good to ensure that we have no C++ problems even if JS tests fail.

@gengjiawen
Copy link
Member

I am inclined to Make lint --> Compile Node.js --> Test C++ Suites --> Test JS Suites.

But there is one thing. @richardlau put some lint task in .github/workflows/CI.yml, should we make lint a standalone task ?

@mmarchini
Copy link

CI will eventually and periodically fail here, because the repository is automatically synced with nodejs/node and then upgraded with the latest version of V8.

If there is a specific issue when building in one platform, or a specific test failing, please open individual issues for it.

As for any changes on the Build/Test/Linter order, this should be handled on nodejs/node.

I'll close this as it doesn't seem there's anything actionable, and the Actions are green right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants