Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ReferenceError: WebAssembly is not defined" with latest (Jan 26) V8 canary build. #188

Closed
nolanmar511 opened this issue Jan 27, 2021 · 6 comments

Comments

@nolanmar511
Copy link

nolanmar511 commented Jan 27, 2021

  • Version: v16.0.0-v8-canary20210126cca63d5c10 (this issue does not occur with v16.0.0-v8-canary20210125331aeb02a3)
  • Platform: 5.7.17-1rodete4-amd64 Build failure on FreeBSD 10 #1 SMP Debian 5.7.17-1rodete4 (2020-10-01) x86_64 GNU/Linux
  • Subsystem: not sure

What steps will reproduce the bug?

Compiling and running our typescript benchmark fails with "WebAssembly is not defined" while reading source maps.

+ node -v
v16.0.0-v8-canary20210126cca63d5c10
+ node --trace-warnings build/src/busybench.js 10
/tmp/tmp.ywAUtcetvv/busybench/node_modules/pprof/out/src/sourcemapper/sourcemapper.js:206
            throw new Error('An error occurred while processing the source map files' + err);
                  ^

Error: An error occurred while processing the source map filesError: An error occurred while reading the sourceMap file /tmp/tmp.ywAUtcetvv/busybench/build/src/busybench.js.map: ReferenceError: WebAssembly is not defined
    at /tmp/tmp.ywAUtcetvv/busybench/node_modules/pprof/out/src/sourcemapper/sourcemapper.js:206:19
    at Generator.throw (<anonymous>)
    at rejected (/tmp/tmp.ywAUtcetvv/busybench/node_modules/pprof/out/src/sourcemapper/sourcemapper.js:21:65)
++ echo '** TEST FAILED **'
+ cd /src/system-test/..
+ npm run clean
** TEST FAILED **

How often does it reproduce? Is there a required condition?

This has reproduced every time we've run our system test with release of the V8 canary build.

What is the expected behavior?

We'd expect no "ReferenceError: WebAssembly is not defined" error to appear.

What do you see instead?

"ReferenceError: WebAssembly is not defined" is thrown while processing source maps.

Additional information

Thanks for maintaining the v8 canary build! Any pointers here would be appreciated.
The latest V8 canary build does seem to have fewer files than the previous (though that could be totally unrelated)

@nolanmar511
Copy link
Author

Wanted to note that this error persists with v16.0.0-v8-canary202101289af183895a.

Is this type of error now expected?

@targos
Copy link
Member

targos commented Jan 28, 2021

I'd say it's not expected, because Chrome Canary doesn't have a problem with WebAssembly as far as I can tell.
I'll check if we need to change something in our build config. There were many commits related to wasm in the last few days: https://github.com/v8/v8/commits/master

@targos
Copy link
Member

targos commented Jan 28, 2021

Okay, I found it: v8/v8@27771482715

WebAssembly is now disabled by default in V8. I'm updating the configuration...

@devsnek
Copy link
Member

devsnek commented Jan 28, 2021

WebAssembly is now disabled by default in V8

fwiw its enabled by default (v8_enable_webassembly = true)

@targos
Copy link
Member

targos commented Jan 29, 2021

@nolanmar511
Copy link
Author

Thanks!
This error went away with the latest V8 canary build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants