deps, v8: fix build torque on Windows #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
refack
force-pushed
the
fix-v8-torque-build-on-windows
branch
2 times, most recently
from
6915796
to
03770e0
Compare
|
P.S. spec'ing at the target level gets this to build with |
|
Full CI: https://ci.nodejs.org/job/node-test-commit/18567/ (✔️ except for flake) |
|
@nodejs/gyp |
bnoordhuis
approved these changes
May 18, 2018
deps/v8/gypfiles/v8.gyp
Outdated
| 'defines!': [ | ||
| '_HAS_EXCEPTIONS=0', | ||
| 'BUILDING_V8_SHARED=1', | ||
| 'BUILDING_UV_SHARED=1', |
There was a problem hiding this comment.
I guess these were the missing keys? (Or rather, not missing...)
There was a problem hiding this comment.
(To figure this out I run the GN recipe and bisected the diff in the generated ninja files. That was not fun)
I guess BUILDING_UV_SHARED is inconsequential.
deps/v8/gypfiles/v8.gyp
Outdated
| 'include_dirs': [ | ||
| '../third_party/antlr4/runtime/Cpp/runtime/src', | ||
| '../src/torque', | ||
| ], | ||
| 'default_configuration': 'Release', |
nodejs-ci
force-pushed
the
canary
branch
3 times, most recently
from
b2733b8
to
491eb0f
Compare
On windows the torque binary needs to be compiled and linked with exception semantics and assume V8 is embedded Fixes: nodejs#57
refack
force-pushed
the
fix-v8-torque-build-on-windows
branch
from
03770e0
to
d125781
Compare
|
CI is as green as it can be (test failure is a known issue). Thanks! |
|
Pushed to canary-base in nodejs/node@11c42e3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows the torque binary needs to be compiled and linked
with exception semantics and assume V8 is embedded
Fixes: #57
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes