From 018159d734edc4132c0ff6660cd509997ca366e5 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Wed, 22 May 2019 18:36:00 -0400 Subject: [PATCH] tools,gyp: introduce MSVS 2019 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Backport-PR-URL: https://github.com/nodejs/node/pull/28005 PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By: Michaël Zasso Reviewed-By: Ujjwal Sharma Reviewed-By: Refael Ackermann Reviewed-By: Matteo Collina Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott --- tools/gyp/pylib/gyp/MSVSVersion.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tools/gyp/pylib/gyp/MSVSVersion.py b/tools/gyp/pylib/gyp/MSVSVersion.py index 44b958d5b3d22e..48a3151f8107e8 100644 --- a/tools/gyp/pylib/gyp/MSVSVersion.py +++ b/tools/gyp/pylib/gyp/MSVSVersion.py @@ -257,6 +257,16 @@ def _CreateVersion(name, path, sdk_based=False): if path: path = os.path.normpath(path) versions = { + '2019': VisualStudioVersion('2019', + 'Visual Studio 2019', + solution_version='12.00', + project_version='16.0', + flat_sln=False, + uses_vcxproj=True, + path=path, + sdk_based=sdk_based, + default_toolset='v142', + compatible_sdks=['v8.1', 'v10.0']), '2017': VisualStudioVersion('2017', 'Visual Studio 2017', solution_version='12.00', @@ -387,6 +397,7 @@ def _DetectVisualStudioVersions(versions_to_check, force_express): 2013(e) - Visual Studio 2013 (12) 2015 - Visual Studio 2015 (14) 2017 - Visual Studio 2017 (15) + 2019 - Visual Studio 2019 (16) Where (e) is e for express editions of MSVS and blank otherwise. """ version_to_year = { @@ -396,7 +407,8 @@ def _DetectVisualStudioVersions(versions_to_check, force_express): '11.0': '2012', '12.0': '2013', '14.0': '2015', - '15.0': '2017' + '15.0': '2017', + '16.0': '2019', } versions = [] for version in versions_to_check: